roslyn Use correct get / set inside ref safety analysis

This fixes a few cases where our code looked at the wrong accessor when doing ref safety analysis.

closes https://github.com/dotnet/roslyn/issues/35606 closes https://github.com/dotnet/roslyn/issues/73550 related https://github.com/dotnet/roslyn/issues/73872 related https://github.com/dotnet/csharplang/pull/8253

Jun 04 '24 18:06 jaredpar

@dotnet/roslyn-compiler PTAL

Jun 13 '24 04:06 jaredpar

@dotnet/roslyn-compiler PTAL

Jun 14 '24 15:06 jaredpar

Thanks for the feedback. Updated.

Jun 18 '24 00:06 jaredpar

Done with review pass (commit 9)

Jun 18 '24 13:06 AlekseyTs

Dropping to draft while I work out a few items.

Jun 27 '24 21:06 jaredpar

@dotnet/roslyn-compiler PTAL. I dismissed previous sign offs because I made substantial changes to the PR.

Jun 28 '24 04:06 jaredpar

FYI: posted a spec update for object initializers around ref safety

https://github.com/dotnet/csharplang/pull/8253

Jun 28 '24 15:06 jaredpar

@cston, @jjonescz, @RikkiGibson PTAL

Jul 08 '24 16:07 jaredpar

/azp run

Jul 11 '24 14:07 jaredpar

Azure Pipelines successfully started running 2 pipeline(s).

Jul 11 '24 14:07 azure-pipelines[bot]