Turn Semantic Snippets off by default

[akhera99]

Removes the feature flag.

[DoctorKrolic]

I think this is a bad idea unless https://github.com/dotnet/roslyn/issues/67739, https://github.com/dotnet/roslyn/issues/71542 and https://github.com/dotnet/roslyn/issues/71570 are fixed. I am a big fun of semantic snippets myself yet I find these bugs extreamly annoying, especially the line endings one. If we turn on semantic snippets now we might get a good portion of hate and rejection of them in future as "something bad"

[akhera99]

I think this is a bad idea unless #67739, #71542 and #71570 are fixed. I am a big fun of semantic snippets myself yet I find these bugs extreamly annoying, especially the line endings one. If we turn on semantic snippets now we might get a good portion of hate and rejection of them in future as "something bad"

Yeah that makes a lot of sense. This was created under the assumption #67739 could be fixed within Roslyn, but it seems to be a platform bug. Changing the PR to turn semantic snippets off by default instead.