roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

FixAllOccurrencesIgnoresGeneratedCode is flaky

Open Cosifne opened this issue 3 years ago • 7 comments

Example build: https://dev.azure.com/dnceng/public/_build/results?buildId=1653816&view=results Example error messages:

System.Exception : No light bulb session in View! Buffer content type=CSharp

System.MissingMethodException : Method not found: 'Microsoft.VisualStudio.Threading.JoinableTaskContext Microsoft.VisualStudio.Shell.ThreadHelper.get_JoinableTaskContext()'.

Runfo Tracking Issue: [Roslyn][Flaky test] CSharp.CSharpCodeActions.FixAllOccurrencesIgnoresGeneratedCode

Build Definition Kind Run Name
568860 roslyn-integration-CI PR 72115 1-Integration Debug OOP64_True OOPCoreClr_False
568860 roslyn-integration-CI PR 72115 1-Integration Debug OOP64_True OOPCoreClr_False
568860 roslyn-integration-CI PR 72115 1-Integration Debug OOP64_True OOPCoreClr_False
568573 roslyn-integration-CI PR 62771 1-Integration Debug OOP64_True OOPCoreClr_False
568573 roslyn-integration-CI PR 62771 1-Integration Debug OOP64_True OOPCoreClr_False
568573 roslyn-integration-CI PR 62771 1-Integration Debug OOP64_True OOPCoreClr_False
568573 roslyn-integration-CI PR 62771 1-Integration Release OOP64_False OOPCoreClr_False
568573 roslyn-integration-CI PR 62771 1-Integration Release OOP64_False OOPCoreClr_False
568573 roslyn-integration-CI PR 62771 1-Integration Release OOP64_False OOPCoreClr_False
568272 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
568272 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
568272 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
567970 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
567970 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
567970 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
567215 roslyn-integration-CI PR 71916 1-Integration Debug OOP64_True OOPCoreClr_False
567215 roslyn-integration-CI PR 71916 1-Integration Debug OOP64_True OOPCoreClr_False
567215 roslyn-integration-CI PR 71916 1-Integration Debug OOP64_True OOPCoreClr_False
567062 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
567062 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
567062 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
567062 roslyn-integration-CI Rolling 1-Integration Release OOP64_False OOPCoreClr_False
567062 roslyn-integration-CI Rolling 1-Integration Release OOP64_False OOPCoreClr_False
567062 roslyn-integration-CI Rolling 1-Integration Release OOP64_False OOPCoreClr_False
566896 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
566896 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
566896 roslyn-integration-CI Rolling 1-Integration Release OOP64_True OOPCoreClr_False
566896 roslyn-integration-CI Rolling 1-Integration Release OOP64_False OOPCoreClr_False
566896 roslyn-integration-CI Rolling 1-Integration Release OOP64_False OOPCoreClr_False
566896 roslyn-integration-CI Rolling 1-Integration Release OOP64_False OOPCoreClr_False
566796 roslyn-integration-CI PR 72106 1-Integration Debug OOP64_True OOPCoreClr_False
566796 roslyn-integration-CI PR 72106 1-Integration Debug OOP64_True OOPCoreClr_False
566796 roslyn-integration-CI PR 72106 1-Integration Debug OOP64_True OOPCoreClr_False
566498 roslyn-integration-CI PR 72090 1-Integration Debug OOP64_True OOPCoreClr_False
566498 roslyn-integration-CI PR 72090 1-Integration Debug OOP64_True OOPCoreClr_False
566498 roslyn-integration-CI PR 72090 1-Integration Debug OOP64_True OOPCoreClr_False
564597 roslyn-integration-CI PR 71869 1-Integration Debug OOP64_True OOPCoreClr_False
564597 roslyn-integration-CI PR 71869 1-Integration Debug OOP64_True OOPCoreClr_False
564597 roslyn-integration-CI PR 71869 1-Integration Debug OOP64_True OOPCoreClr_False
563382 roslyn-integration-CI PR 62741 1-Integration Debug OOP64_True OOPCoreClr_False
563382 roslyn-integration-CI PR 62741 1-Integration Debug OOP64_True OOPCoreClr_False
563382 roslyn-integration-CI PR 62741 1-Integration Debug OOP64_True OOPCoreClr_False

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 11

Cosifne avatar Sep 22 '21 21:09 Cosifne

Probable cause is integration tests are not waiting for async light bulb to show all items

sharwell avatar Sep 29 '21 21:09 sharwell

@sharwell same question. Do you still think this is async lightbulbs? And, if so, are yous till seeing this?

CyrusNajmabadi avatar Dec 15 '21 17:12 CyrusNajmabadi

I'm not sure on the status of this one

sharwell avatar Dec 15 '21 17:12 sharwell

This test is still flaky; updating the RunFo query momentarily to reflect this.

allisonchou avatar Mar 09 '22 22:03 allisonchou

@CyrusNajmabadi @sharwell we're still seeing this issue in newer builds. Is this an issue with async lightbulbs?

allisonchou avatar Mar 09 '22 22:03 allisonchou

@allisonchou Yes, this is known. It should be fixed by #60048 , but that is blocked on some other prerequisites.

sharwell avatar Mar 10 '22 19:03 sharwell

Assigned to @sharwell since he seems to be working on a fix. Thanks

jcouv avatar Mar 17 '22 17:03 jcouv