roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Inline Diagnostics TaggerDelay

Open akhera99 opened this issue 3 years ago • 5 comments

Here are two videos with differing TaggerDelays to make it so the diagnostics do not feel as obstructive. Please let me know which one you find more appealing 👍

Medium Delay:

https://user-images.githubusercontent.com/40616383/133143137-4c3fcc65-d4e3-4c53-90d3-8497ec7a3d5b.mp4

OnIdle Delay

https://user-images.githubusercontent.com/40616383/133143203-1d840aeb-fbd0-4f31-ac94-366ed99c3674.mp4

@mikadumont

akhera99 avatar Sep 13 '21 19:09 akhera99

So the videos don't really reflect the scenario we care about here. They show the experience around editing+waiting and seeing how long it takes. The scenario that matters is that during normal coding, with constant typing/navigation/features that these items don't appear too flashy.

That said, squiggles on OnIdle i believe, so i would fully expect these squiggles to be OnIdle as the fatest we would ever make them. They should not be faster than squiggles themselves.

CyrusNajmabadi avatar Sep 13 '21 19:09 CyrusNajmabadi

So the videos don't really reflect the scenario we care about here. They show the experience around editing+waiting and seeing how long it takes. The scenario that matters is that during normal coding, with constant typing/navigation/features that these items don't appear too flashy.

That said, squiggles on OnIdle i believe, so i would fully expect these squiggles to be OnIdle as the fatest we would ever make them. They should not be faster than squiggles themselves.

Squiggles are on Short, I can create new videos. I was trying to show the disparity of time it takes for items to get removed/added.

akhera99 avatar Sep 13 '21 19:09 akhera99

hrm... something in the squiggle pipeline thought shoudl be adding the 1.5 second delay we expect to not make it too flashy.

CyrusNajmabadi avatar Sep 13 '21 19:09 CyrusNajmabadi

Medium:

https://user-images.githubusercontent.com/40616383/134599442-c78dfe2e-a5af-400a-acb7-fde7189473d3.mp4

OnIdle:

https://user-images.githubusercontent.com/40616383/134599460-fd3ac834-fd52-446b-89e3-3e7fffe71380.mp4

akhera99 avatar Sep 24 '21 00:09 akhera99

Retarget this to main because 17.1 branch is not used and main is 17.1 now

Cosifne avatar Sep 28 '21 04:09 Cosifne