roslyn-sdk icon indicating copy to clipboard operation
roslyn-sdk copied to clipboard

Example hello world generator shouldn't iterate trees

Open chsienki opened this issue 3 years ago • 1 comments

Our sample hello world generator iterates over the syntax trees. We explicitly tell people not to do this, and use a syntax receiver instead (and want to add an analyzer in the future too).

We should update the sample to not iterate the trees but do something else instead.

chsienki avatar Sep 02 '20 20:09 chsienki

Iterating over syntax trees is only a problem if you are iterating over the SyntaxNode root of the tree. This generator does not call GetRoot[Async|Synchronously] so there is no need to change it.

sharwell avatar Dec 23 '20 05:12 sharwell