roslyn-sdk icon indicating copy to clipboard operation
roslyn-sdk copied to clipboard

Added wizard and nuget references to CSharp Analyzer Item Template

Open peteraritchie opened this issue 5 years ago • 7 comments

Addresses #374

peteraritchie avatar Aug 07 '19 05:08 peteraritchie

After this change, what will happen if the template is used in a project that has a reference to the 2.0 release of Microsoft.CodeAnalysis?

sharwell avatar Aug 07 '19 19:08 sharwell

After this change, what will happen if the template is used in a project that has a reference to the 2.0 release of Microsoft.CodeAnalysis?

I was assuming that templates intelligently install versions of nuget packages. But, it's not appearing to be a correct assumption. Can you confirm?

peteraritchie avatar Aug 10 '19 23:08 peteraritchie

It's hard to tell from the documentation how this would behave. I'm not sure I'd be comfortable having the template force package upgrades, but at the same time I never use the templates myself so I'm not sure it matters.

sharwell avatar Oct 10 '19 19:10 sharwell

@peteraritchie this looks good. Could you also add these nuget dependencies for the other item templates?

jmarolf avatar Oct 14 '19 17:10 jmarolf

/azp run

jmarolf avatar Oct 14 '19 17:10 jmarolf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 14 '19 17:10 azure-pipelines[bot]

I'm still uncomfortable with having the item templates changing package references.

Can you explain your objection? Other item templates do this

jmarolf avatar Jul 16 '20 16:07 jmarolf