roslyn-sdk icon indicating copy to clipboard operation
roslyn-sdk copied to clipboard

Include commit hash in NuGet packages

Open sharwell opened this issue 7 years ago • 5 comments

Currently the commit hash isn't present in the NuGet packages: https://dotnet.myget.org/feed/roslyn-analyzers/package/nuget/Microsoft.CodeAnalysis.Analyzer.Testing

It would be nice to include it so it's clear where the code comes from.

sharwell avatar Sep 07 '18 18:09 sharwell

@tmat how do we enable this on repo-toolset?

jmarolf avatar Sep 07 '18 19:09 jmarolf

It is in the nuspec:

    <repository type="git" url="https://github.com/dotnet/roslyn-sdk" commit="bfeea090ade1b6c6ecc243066cd272c1e784d14d" />

Do you mean include it in the version of the package?

tmat avatar Sep 07 '18 19:09 tmat

Interesting. I guess MyGet needs to be updated to show the information.

Maybe we can add it to the Release Nodes section of the package so it shows like we get for roslyn packages?

sharwell avatar Sep 07 '18 20:09 sharwell

I guess MyGet needs to be updated to show the information.

Yes, they do.

Maybe we can add it to the Release Nodes section of the package so it shows like we get for roslyn packages

We can do that. I'd rather push on NuGet to display the info though.

tmat avatar Sep 07 '18 22:09 tmat

Actually, once we include the commit SHA in package version/name it won't be needed in the Release Notes section anyways.

tmat avatar Sep 07 '18 22:09 tmat