roslyn-sdk
roslyn-sdk copied to clipboard
Release 1.1.2 which contains `ReferenceAssemblies.Net.Net70`
Currently, the latest stable on NuGet doesn't contain ReferenceAssemblies.Net.Net70
.
Can 1.1.2 be released on NuGet.org?
@arkalyanms @jmarolf @sharwell
We were able to work around this by inlining the change: https://github.com/dotnet/roslyn-sdk/blob/ba5f8a6bf7b477b44a43ea943d3e831d6301afb7/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/ReferenceAssemblies.cs#L986-L991
@sharwell @arkalyanms @jmarolf Can this be addressed soon? The fix from https://github.com/dotnet/roslyn-sdk/pull/988 is very important and can't be easily worked-around.
I won't be able to add https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json
for now.
@sharwell Are there any plans on releasing new version? Even though there is a workaround for adding .NET 7 reference assemblies, there are importand bug fixes and features, that cannot be workarounded so easily (e.g. https://github.com/dotnet/roslyn-sdk/pull/1071 or https://github.com/dotnet/roslyn-sdk/pull/1079). It isn't costly to do that, is it?
This was being handled by a specific individual as a side project previously. All of our automation only handles getting things to the dotnet-tools feed. That person and the second person who would have handled it in their absence were relocated to another team as part of the recent reorganization, so we are short staffed and specifically hit in the area for this issue. I'm not sure what the plans are for resolving it.
That's unfortunate 🙁. I hope these staff issues will be resolved soon. Tell your managers, that this is small yet very important library for external roslyn users. In the meanwhile what is the schedule of automated dotnet-tools releases? When will latest changes be there as a part of some 1.2-beta-x
version?
In the meanwhile what is the schedule of automated dotnet-tools releases?
Every merge is published as soon as the build completes. Latency on that pipeline appears to be completing about an hour after the PR merges, but it can vary based on load at the time.
Any update on getting this released to NuGet.org? There are some internal repos which need #1097 to resolve some security alerts.
@dfederm If referencing the dotnet-tools feed is not possible in your project, you should be able to manually reference the updated version of the dependencies to avoid the warnings.
Is there any update on this? The version of this package on public NuGet (v1.1.1) is now two major releases of .Net behind in terms of the support for ReferenceAssemblies for analyzer tests. I'm trying to update a solution which includes analyzers to .Net 8.0 and I'm blocked by this issue.
Just in case anyone is looking for a simple workaround until this is fixed:
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<!-- Add nuget registry containing latest package version. -->
<RestoreAdditionalProjectSources>
https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json;
</RestoreAdditionalProjectSources>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis" Version="4.8.0"/>
<!-- Add package version compatible with .NET 8 -->
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing" Version="1.1.2-beta1.23431.1"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0"/>
</ItemGroup>
</Project>
@sharwell we need to CG fixes from https://github.com/dotnet/roslyn-sdk/pull/1148 - when will 1.1.2 be release on nuget.org? This is now a critical security hole. WiIl try to add dnceng feed as an upstream.
edit: adding upstream worked, but it's a bummer the latest version on nuget.org has a security issue.
Now .NET8.0 is out quite a long time and still preview is needed to use 'ReferenceAssemblies.Net.Net80'. What is the logic for having such a long preview phase?
What is the logic for having such a long preview phase?
@b-straub This was already covered by https://github.com/dotnet/roslyn-sdk/issues/1047#issuecomment-1523360798
@b-straub This was already covered by #1047 (comment)
This comment is from a year ago, so something should have changed meanwhile …
@b-straub It has not. 😄