razor icon indicating copy to clipboard operation
razor copied to clipboard

Add missing integration test for telemetry testing

Open maryamariyan opened this issue 2 years ago • 2 comments

Currently Diagnostic integration tests are skipped due to https://github.com/dotnet/razor/issues/8150

We'll want an integration test that validates the telemetry events we are interested are fired when expected.

/cc @ryzngard

maryamariyan avatar Jun 02 '23 20:06 maryamariyan

Just my personal opinion, but tests for telemetry seem unnecessary to me, and I can't think how we would do them with our current testing tech without comprising the quality of the code.

davidwengier avatar Jun 02 '23 21:06 davidwengier

I would say that integration tests specifically for telemetry are not needed, but adding telemetry checks to integration tests would be useful to validate we expect certain things to be fired

ryzngard avatar Jun 02 '23 21:06 ryzngard