razor icon indicating copy to clipboard operation
razor copied to clipboard

Add route string syntax to Razor pages and Blazor

Open JamesNK opened this issue 1 year ago • 4 comments

Fixes https://github.com/dotnet/razor-compiler/issues/352

I've hacked this in. There are things todo:

  1. Is this the right way to detect whether a Razor document is a Razor Page or Blazor page?
  2. I was surprised when I ran the unit tests and nothing failed. It appears the razor compiler unit tests aren't in the solution file? If they're somewhere in the repo then I still need to update them.

JamesNK avatar Oct 18 '22 00:10 JamesNK

It works:

image

🥳 🎈 🚀 🎉

cc @CyrusNajmabadi

JamesNK avatar Oct 18 '22 00:10 JamesNK

It does look like there are some test failures.

333fred avatar Oct 18 '22 00:10 333fred

Done review pass (commit 2)

333fred avatar Oct 18 '22 01:10 333fred

At least we know CI seems to build the compiler bits on PRs.. I honestly wasn't sure :)

davidwengier avatar Oct 18 '22 01:10 davidwengier

@dotnet/razor-compiler for a second review please.

333fred avatar Oct 21 '22 22:10 333fred

Thanks @JamesNK!

333fred avatar Oct 25 '22 21:10 333fred