razor icon indicating copy to clipboard operation
razor copied to clipboard

Remove single server feature flags

Open davidwengier opened this issue 3 years ago • 1 comments

Logging this so we don't forget: We currently have feature flags for single server completion, and single server everything-else.

We should remove these in 17.6 if we don't get negative signal about issues over the course of 17.4.

davidwengier avatar Oct 12 '22 02:10 davidwengier

@allisonchou says we need to do this for VS Code as well.

DustinCampbell avatar Oct 13 '22 21:10 DustinCampbell

Yeah, removing the actual HtmlCSharp server is separate, since VS Code needs it. I just meant removing the feature flags from the Preview Features options screen in VS. The functionality would still be there, and behind the LangaugeServerFeatureOptions infra we already have :)

davidwengier avatar Nov 02 '22 06:11 davidwengier

Note: This is in 17.5 Planning, because we want it to be surfaced for 17.6. This will happen once #6576 is done in 17.5.

DustinCampbell avatar Nov 02 '22 23:11 DustinCampbell

removing the actual HtmlCSharp server is separate, since VS Code needs it

I was wrong, VS Code doesn't need this.

What VS Code needs is to have more endpoints available in "single server" mode. For this reason we can't remove the properties from LanguageServerFeatureOptions in our codebase, but we can remove the feature flags that we have to control those options.

davidwengier avatar Jun 19 '23 22:06 davidwengier