razor icon indicating copy to clipboard operation
razor copied to clipboard

Enum member coloration wrong in Razor files

Open ryanbrandenburg opened this issue 4 years ago • 9 comments

image

We'll likely need to apply a fix similar to what we did in https://github.com/dotnet/razor-tooling/issues/4686.

ryanbrandenburg avatar Oct 15 '21 17:10 ryanbrandenburg

Hi @ryanbrandenburg

I reported this issue on VS Feedback. I'm writing to you here as I cannot add a comment on the thread here since you've closed it. https://developercommunity.visualstudio.com/t/Revert-razor-color-highlighting-to-defau/1551058?entry=myfeedback&viewtype=all&space=8&scope=follow

According to circle 3: What is the intention for this change? All razor syntax was purple and bold by default. Why are you threating @xxx now differently? IMO it doesn't make sense to seperate it from the other razor highlighting since this is still razor.

MarvinKlein1508 avatar Oct 27 '21 09:10 MarvinKlein1508

@MarvinKlein1508: regarding circle 3, we made a bunch of changes to Razor coloration in VS with an eye toward accessibility and a more visually pleasing Razor page, of which Razor Directive Attribute was one. If you feel that the previous coloration was a better default I recommend filing an issue here to that effect and letting it collect feedback from the rest of the community. If there's a lot of consensus we can re-consider when we make our next pass at default colors

ryanbrandenburg avatar Oct 27 '21 16:10 ryanbrandenburg

A good resolution here would be that VS provides explicit colors for all "basic" classifications rather than relying on the default to "Plain Text".

ryanbrandenburg avatar Nov 02 '21 22:11 ryanbrandenburg

Spoke with Cherry about this, it's unlikely this will happen before 17.1P3, but they are receptive to this change.

ryanbrandenburg avatar Nov 09 '21 23:11 ryanbrandenburg

More related feedback items:

  • https://developercommunity.visualstudio.com/t/VS-2022-Razor-Code-Background-setting-is/1580395

NTaylorMullen avatar Nov 11 '21 18:11 NTaylorMullen

Lets poke the thread here and see what the status is.

ryanbrandenburg avatar Jan 31 '22 19:01 ryanbrandenburg

I tried a repo and this seems to be fixed? Checking with Cherry to see if this went in while I wasn't looking.

ryanbrandenburg avatar Feb 14 '22 22:02 ryanbrandenburg

Oh, duh. It looked fixed because of https://github.com/dotnet/razor-tooling/pull/5794, but that's only a temporary solution. We'd like a long term fix to this.

ryanbrandenburg avatar Mar 08 '22 19:03 ryanbrandenburg

The internal tracking issue for this is https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1495253?src=WorkItemMention&src-action=artifact_link.

ryanbrandenburg avatar Jul 07 '22 20:07 ryanbrandenburg