razor icon indicating copy to clipboard operation
razor copied to clipboard

Wire up UseRoslynTokenizer in Visual Studio

Open davidwengier opened this issue 1 year ago • 1 comments

Bring's @333fred's compiler work to bear in VS by adding a new field to ProjectWorkspaceState to represent the flag, and serialize it across the wire etc.

Makes this work: Image

davidwengier avatar Oct 25 '24 04:10 davidwengier

Since most of your comments were on the other PR, I replied there. I didn't think you looked at draft PRs 😛

davidwengier avatar Oct 26 '24 02:10 davidwengier

Closing is favour of https://github.com/dotnet/razor/pull/11092

davidwengier avatar Oct 28 '24 03:10 davidwengier

I didn't think you looked at draft PRs 😛

No, I will absolutely look at a draft PR and offer feedback if I think it's useful. For example, If I see that a draft PR is going in a particular direction that could use some discussion, I'll definitely leave feedback. Also, if there's a PR comment that indicates that feedback might be useful to person who submitted the draft PR, I'll take a look. Otherwise, I won't look at a draft PR to avoid wasting my time and the submitter's time.

What I really find annoying, is when somebody "approves" a draft PR. That is an egregious bit of engineering laziness IMO. 😛 😜 😝

DustinCampbell avatar Oct 28 '24 15:10 DustinCampbell