project-system Synchronise language service project updates

Ensures a workspace will not be disposed during an update by wrapping the update in ExecuteUnderLockAsync.

Diff looks worse than it is. Recommend viewing without white space changes.

Microsoft Reviewers: Open in CodeFlow

Mar 03 '23 03:03 drewnoakes

@drewnoakes @tmeschter So this meant you were potentially updating a project while it was being disposed at the same time? I wonder if that explains a bunch of bugs I've been seeing that I haven't been able to track down....

Mar 06 '23 18:03 jasonmalinowski

@jasonmalinowski Possibly. More likely if the issues you were seeing involved ObjectDisposedExceptions.

Mar 07 '23 00:03 tmeschter

/azp run

Mar 07 '23 23:03 drewnoakes

Azure Pipelines successfully started running 1 pipeline(s).

Mar 07 '23 23:03 azure-pipelines[bot]

@drewnoakes We've been hitting concurrency issues with the agent pool all day. If you look at the graph here and add the currently running jobs + queued jobs, it'll be around 820, which is the max for the agent pool. We'll just have to wait. https://dev.azure.com/dnceng-public/public/_settings/agentqueues?queueId=13&view=analytics

Mar 07 '23 23:03 MiYanni

@jasonmalinowski Possibly. More likely if the issues you were seeing involved ObjectDisposedExceptions.

Nothing specifically with object disposed exceptions, but we were seeing bugs where we'd potentially try creating references to projects that are missing, or things like that. If it's possible you were removing a project from the workspace and also adding/removing output paths for it at the same time, we might have gotten into those bad states.

Mar 08 '23 00:03 jasonmalinowski

/azp run

Mar 08 '23 20:03 drewnoakes

Azure Pipelines successfully started running 1 pipeline(s).

Mar 08 '23 20:03 azure-pipelines[bot]

@drewnoakes We've been hitting concurrency issues with the agent pool all day. If you look at the graph here and add the currently running jobs + queued jobs, it'll be around 820, which is the max for the agent pool. We'll just have to wait. https://dev.azure.com/dnceng-public/public/_settings/agentqueues?queueId=13&view=analytics

I think the failure is actually related to this PR somehow. Other PRs are building. I will investigate later as it's late here now.

FYI @tmeschter

Mar 09 '23 11:03 drewnoakes

@drewnoakes A quick review of the build output does look like it could be hanging in the unit test run. :-(

Mar 14 '23 21:03 tmeschter