Silo Lifecycle Events

Open ledjon-behluli opened this issue 1 month ago • 4 comments

close #9771

Microsoft Reviewers: Open in CodeFlow

Nov 18 '25 22:11 ledjon-behluli

@ReubenBond addressed the comments, PTAL!

WDYT about this, I am unsure, but lean more towards (a)waiting indefinitely

Nov 19 '25 23:11 ledjon-behluli

@ledjon-behluli I think relying on them respecting the CT is ok (even if not defensive)

Nov 25 '25 04:11 ReubenBond

@ReubenBond Added proper tests & removed the toy/test console app. We should consider not having the TerminateOnError and control it within the component i.e. Starting events should terminate, and while stopping we log and swallow, but other than that this is now ready AFAIC.

P.s: I do not have a strong opinion on the matter of TerminateOnError being an internal thing, or left to the user.

Nov 30 '25 15:11 ledjon-behluli

Yes please!

Dec 01 '25 18:12 shacal