orleans
orleans copied to clipboard
Fix leaking timed-out callbacks in InsideRuntimeClient
Callbacks for timed-out request messages in InsideRuntimeClient were never removed because they were unregistered by msg.TargetGrain, instead of msg.SendingGrain.
Microsoft Reviewers: Open in CodeFlow
@dotnet-policy-service agree
Just to note: I'm not quite happy with adding the GetRunningRequestsCount method to IRuntimeClient only for testing purposes, and I'm not sure that this leak should be tested at all
Just to note: I'm not quite happy with adding the GetRunningRequestsCount method to IRuntimeClient only for testing purposes, and I'm not sure that this leak should be tested at all
It's ok, I'll just put a note there saying that it's for testing purposes only. We have a pattern of exposing test hooks via a test-specific interface. That would be an alternative approach, but I don't feel it's necesarry here.