orleans icon indicating copy to clipboard operation
orleans copied to clipboard

Unable to find UseAzureTableReminderService on Microsoft.Orleans.Reminders.AzureStorage v3.6.x onward

Open Desz01ate opened this issue 3 years ago • 4 comments

Refer to https://dotnet.github.io/orleans/docs/grains/timers_and_reminders.html#configuration

I was able to find UseAzureTableReminderService on Microsoft.Orleans.Reminders.AzureStorage v3.5.1 just fine, however when upgrading to v3.6.x the extension method is nowhere to be found, is it renamed or am I missing something?

Desz01ate avatar Jul 25 '22 11:07 Desz01ate

The extension method is applied to both ISiloHostBuilder and ISiloBuilder in v3.5.1. But the method is only applied to ISiloBuilder in v3.6.2.

Is there any reason for that change?

Thanks

taurusni avatar Aug 04 '22 10:08 taurusni

Sorry I thought I already responded to that issue.

@Desz01ate We changed how to configure the azure storage providers. Now it can be configured like this: builder.UseAzureTableReminderService(connectionString)

@taurusni ISiloHostBuilder is deprecated, you should use ISiloBuilder instead.

benjaminpetit avatar Aug 04 '22 14:08 benjaminpetit

@benjaminpetit thanks for the solution!

Desz01ate avatar Aug 04 '22 14:08 Desz01ate

@benjaminpetit Thanks for the clarification.

However, the https://docs.microsoft.com/en-us/dotnet/api/orleans.hosting.isilohostbuilder?view=orleans-3.0 doesn't mention that and the migration from ISiloHostBuilder to ISiloBuilder is not seamlessly. For example, OrleansServiceListener still depends on the ISiloHostBuilder

Will ISiloHostBuilder be obsolete in Orleans 4.0?

Thanks in advance.

taurusni avatar Aug 05 '22 01:08 taurusni

@taurusni sorry missed the last message.

Yes ISiloHostBuilder is removed from 4.0

benjaminpetit avatar Sep 06 '22 12:09 benjaminpetit

@benjaminpetit Thanks for the clarification.

However, the https://docs.microsoft.com/en-us/dotnet/api/orleans.hosting.isilohostbuilder?view=orleans-3.0 doesn't mention that and the migration from ISiloHostBuilder to ISiloBuilder is not seamlessly. For example, OrleansServiceListener still depends on the ISiloHostBuilder

Will ISiloHostBuilder be obsolete in Orleans 4.0?

Thanks in advance.

@taurusni were you able to figure out how to migrate from ISiloHostBuilder to ISiloBuilder when upgrading to 3.6.x? I am not seeing a method exposed on the OrleansServiceListener which would accept ISiloBuilder so not sure how to fix that? @benjaminpetit any thoughts?

thakursagar avatar Sep 14 '22 16:09 thakursagar

For the Service Fabric case, we recommend a different approach. We recommend integrating IHost with the SF communication listener lifetime and adding Orleans to that IHost (via the IHostBuilder.UseOrleans(...) extension method). For an example, see: HostedServiceStatelessService

ReubenBond avatar Sep 14 '22 16:09 ReubenBond

@thakursagar I didn't do the migration. Will do that when I can not avoid. The missing function is maintained locally for the time being.

@ReubenBond Thanks for the suggestion.

taurusni avatar Sep 15 '22 11:09 taurusni