orleans icon indicating copy to clipboard operation
orleans copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Issue 7396 add change to timer

Open lukepatterson31 opened this issue 2 years ago • 5 comments

follow up from this PR: [https://github.com/dotnet/orleans/pull/7396] Issue #7396

Microsoft Reviewers: Open in CodeFlow

lukepatterson31 avatar Feb 22 '22 15:02 lukepatterson31

CLA assistant check
All CLA requirements met.

dnfadmin avatar Feb 22 '22 15:02 dnfadmin

#7396 looks relatively innocent, but making the timer mutable could lead to unwanted consequences. Very curious to see what other reviewers have to say.

PiotrJustyna avatar Feb 22 '22 15:02 PiotrJustyna

Apologies for the late question. I want to get to this one ASAP. Was the original PR abandoned, is that why you opened this one?

ReubenBond avatar Mar 24 '22 19:03 ReubenBond

Apologies for the late question. I want to get to this one ASAP. Was the original PR abandoned, is that why you opened this one?

Yes, we saw the issue was labelled as help needed and we wanted to see what can be done. Having made the change, though, I’m not sure how useful it would actually be in the real world…

PiotrJustyna avatar Mar 24 '22 22:03 PiotrJustyna

Apologies for the late question. I want to get to this one ASAP. Was the original PR abandoned, is that why you opened this one?

If there's still interest in implementing the change I'm happy to work on it. As @PiotrJustyna suggested next step is making the timer a property with public getter and private setter. I'd appreciate any thoughts/comments

lukepatterson31 avatar Apr 06 '22 11:04 lukepatterson31