msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Release 17.10

Open YuliiaKovalova opened this issue 1 year ago • 2 comments

(adapted from #9484)

Preparation for the release:

  • [x] Create vs17.10 branch
  • [x] Modify the VS insertion so that it flows from MSBuild vs17.10 to VS main here Edit -> Schedule set under Artifacts -> disable toggle AND
  • [x] Disable automated run of https://dev.azure.com/devdiv/DevDiv/_release?definitionId=2153&view=mine&_a=releases (because our 17.11 builds don't have a place to go in VS yet)
  • [x] Create darc channel for VS 17.11 if it doesn't already exist
    darc add-channel --name "VS 17.11"
  • [x] Ping internal "First Responders" Teams channel to get the new channel 17.11 made available as a promotion target IT SEEMS TO BE DONE https://github.com/dotnet/arcade/pull/14260
  • [x] Remove the main to old release channel default channel
    darc delete-default-channel --repo https://github.com/dotnet/msbuild --branch main --channel "VS 17.9"
  • [x] Associate the main branch with the next release channel
    darc add-default-channel --channel "VS 17.11" --branch main --repo https://github.com/dotnet/msbuild
  • [x] Check subscriptions for the current channel VS 17.11 and update as necessary (for instance, SDK's main branch should usually be updated, whereas release branches often should not be
    darc get-subscriptions --exact --source-repo https://github.com/dotnet/msbuild --channel "VS 17.11"
  • [x] Update channel VS 17.9 to VS 17.10 for the sdk main subscription `darc update-subscription --id sdk_main_branch_id
  • [x] Ensure that the current release channel VS 17.10 is associated with the correct release branch
    darc get-default-channels --source-repo https://github.com/dotnet/msbuild --branch vs17.10
    if it is not, darc add-default-channel --channel "VS 17.10" --branch vs17.10 --repo https://github.com/dotnet/msbuild
  • [x] Fast-forward merge the correct commit (the one that is currently inserted to VS main) to the vs17.10 branch
    e.g.: git push upstream 2e6f2ff7ea311214255b6b2ca5cc0554fba1b345:refs/heads/vs17.10 Note the commit for future steps This steps is aimed to make us sure the branch contains all the planned changes from main
  • [x] Update the branch merge flow in dotnet/versions to have the currently-in-servicing branches (pending review https://github.com/dotnet/versions/pull/951)
  • [x] Fix OptProf data flow for the new vs17.10 branch
    • Run manually OptProf pipeline for vs17.10 ('Run pipeline' in upper right)
    • Run the MSBuild pipeline for vs17.10 without OptProf (set SkipApplyOptimizationData variable in 'Advanced options' section of the 'Run pipeline' menu to true)
    • Run the MSBuild pipeline for vs17.10 with no extra customization - OptProf should succeed now
  • [x] Create 17.11 branding PR (in main)
  • [x] Create 17.10 localization ticket: https://aka.ms/ceChangeLocConfig (requesting to add localization for 17.10) https://ceapex.visualstudio.com/CEINTL/_workitems/edit/957875 (DONE)
  • [x] Enable 17.10 localization - by setting EnableReleaseOneLocBuild to true
  • [x] Disable 17.9 localization - by setting [EnableReleaseOneLocBuild] (https://github.com/dotnet/msbuild/blob/vs17.9/.vsts-dotnet.yml) to false clarify with @JanKrivanek
  • [x] Merge 17.11 branding PR
  • [ ] Create and merge PR including public API baseline package version change (see https://github.com/dotnet/msbuild/pull/8116#discussion_r1049386978): #8949
  • [x] When VS main snaps to 17.10 and updates its version to 17.11, modify the VS insertion so that it flows from MSBuild main to VS main.
  • [x] Create 17.9 localization ticket: https://aka.ms/ceChangeLocConfig (requesting to remove localization for 17.9) https://ceapex.visualstudio.com/CEINTL/_workitems/edit/936778
  • [ ] Remove MSBuild main from the experimental VS insertion flow.
  • [x] Update the release-branch insertion release definition to have InsertTargetBranch rel/d17.10.
  • [x] Turn the release pipeline back on.
  • [x] Prepare final branding PR for vs17.10
  • [x] Merge final branding to vs17.10 branch
  • [ ] Update perfstar MSBuild insertions configuration: example PR
  • [x] Note down the build (will be helpful for requesting nuget packages publishing): (https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9505483&view=results)
  • [x] Get QB approval (RAINER)
  • [x] Merge to VS (babysit the automatically generated VS insertion PR https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequests for the MSBuild commit noted in above step): https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/518456 (RAINER)
  • [x] ~Update the PackageValidationBaselineVersion to the latest released version (17.10.0) - this might require temporary addition of build artifacts feed as the new version is not yet added to the official feeds (this is post release). This can trigger a high severity CG error (https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/secure-supply-chain/how-to-securely-configure-package-source-files) - however it should be fine to keep this temporary feed untill the release.~

ASAP On/After GA (based on release schedule (internal) (~May 21) https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/10097/Dev17-Release):

  • [ ] Push packages to nuget.org (not currently automated, contact dnceng - search "Publish MSBuild 17.6 to NuGet.org" email subject for template).
  • [ ] Publish docs: submit reference request at https://aka.ms/publishondocs
    • Click on the link labeled Request – Reference Publishing
    • You can use existing ticket as a reference
  • [ ] ~Remove the temporarily added build feed from nuget.config if it was added in the Update the PackageValidationBaselineVersion step~
  • [ ] Update main subscriptions to the new channel (this can be done before or after release - depending on when the source repos from our previous - VS 17.10 - channle start to publish in the next - VS 17.11 - channel)
    darc get-subscriptions --exact --target-repo https://github.com/dotnet/msbuild --target-branch main
  • [ ] Create the 17.10 release
    • [ ] Create tag (can be done upfront)
    git checkout <commit noted above>
    git tag v17.10.3
    git push upstream v17.10.3
    
    • [ ] Create Release in Github with Create Release from Tag GH option (https://github.com/dotnet/msbuild/releases/new?tag=v17.9.3) - the release notes can be prepopulated (Generate Release Notes)

YuliiaKovalova avatar Mar 25 '24 12:03 YuliiaKovalova

@surayya-MS can you redo these two parts ASAP please? See internal https://teams.microsoft.com/l/message/19:[email protected]/1712004417168?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4ba7372f-2799-4677-89f0-7a1aaea3706c&parentMessageId=1712004417168&teamName=.NET%20Developer%20Experience&channelName=MSBuild&createdTime=1712004417168

  • [x] Ping internal "First Responders" Teams channel to get the new channel 17.11 made available as a promotion target (note: PR https://github.com/dotnet/arcade/pull/14676)
  • [x] Associate the main branch with the next release channel darc add-default-channel --channel "VS 17.11" --branch main --repo https://github.com/dotnet/msbuild

rainersigwald avatar Apr 01 '24 21:04 rainersigwald

@maridematte please finish On/After GA part when it is time

surayya-MS avatar Apr 30 '24 14:04 surayya-MS

All seems to be done for the release

AR-May avatar Jul 31 '24 11:07 AR-May