msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

[Bug]: IEventSource3.IncludeTaskInputs() doesnt actually include Task Input events

Open baronfel opened this issue 1 year ago • 3 comments

Issue Description

In the use-sourceroot-for-relative-paths branch I'm working on extending Terminal Logger to read the SourceRoot items in the build to discover the current git repo, if any. This is done by

a) opting in to Task Input events b) reacting to the TaskParameterEventArgs events

However, the opt-in from IEventSource3.IncludeTaskInputs() isn't causing the events to be fired.

Steps to Reproduce

  • Clone the use-sourceroot-for-relative-paths branch
  • Build msbuild with ./build.cmd
  • Copy MSbuild to an 8.0.2xx .NET SDK installation with the enlistment scripts
  • Set MSBUILDDEBUGONSTART to 2
  • build a project that's in a git repo
  • attach a debugger to line 705 in the TerminalLogger.cs file
  • see the breakpoint is never hit

Expected Behavior

TaskParameterEventArgs events should be sent to the logger

Actual Behavior

No TaskParameterEventArgs events are fired

Analysis

Per @ladipro, LoggingService.IncludeTaskInputs is not plumbed to interact with BuildParameters.LogTaskInputs.

Versions & Configurations

No response

baronfel avatar Feb 29 '24 15:02 baronfel