msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Analyzers prototyping - Representative analyzers set

Open JanKrivanek opened this issue 1 year ago • 1 comments

Context

#9627

  • Let's go through ideas and build interesting initial set
  • Mark the analyzers in the set based on viability based on EventArgs ('Doable today', 'Doable with slight adjust of EventArgs with minimum implementation and perf cost', 'More complicated')
  • Let's choose few from the first 2 categories above, Expose OM for them and author them

The main part should be the last point

FYI @ladipro (this is based on your suggestion)

References

JanKrivanek avatar Jan 11 '24 12:01 JanKrivanek

Candidates:

Top 3 by @rainersigwald:

  • project-instance races with the same bin/obj
  • double writes
  • forbidding References to outputs of this repo (in favor of ProjectReferences)

Other top candidates:

  • https://github.com/dotnet/msbuild/issues/9781
  • Mixing TargetFramework and TargetFrameworks in a single project - very easy to check, and there is probably no logitimate usage for the case.

JanKrivanek avatar Jan 30 '24 14:01 JanKrivanek

Here's the list of analyzers we would like to ship, each with its own issue:

  • #9879
  • #9880
  • #9881
  • #9882
  • #9883
  • #9884
  • #9885
  • #9888
  • #9889
  • #9891
  • #9892

I'll close this one and we'll continue in individual issues. Each proposed analyzer is a bit different and the devil is in the details, as they say.

ladipro avatar Mar 19 '24 15:03 ladipro

This seems relevant to #1777

stan-sz avatar Apr 15 '24 09:04 stan-sz