msbuild
msbuild copied to clipboard
[WIP] Fix flaky CanShutdownServerProcess test
Context
We detected flaky unit tests related to msbuild server shutdown. Example of failing checks: https://github.com/dotnet/msbuild/pull/7835
Changes Made
Although I do not fully understand root cause, It seems to be related to race condition in Linux between process is finished Process.WaitForExit() and releasing its owned mutexes.
Testing
Several /azp run s
Notes
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
The current test failure is from OldNugetTest. Are we using the server by default now? If so, it may be creating a server process, then expecting it to exit, and it doesn't (nor should it). If that's it, we may need to disable the server for that test.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run