msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Add note when updating system.memory

Open benvillalobos opened this issue 1 year ago • 1 comments

Context

We have customer projects break when we update system.memory, we should make it easier for customers to figure out these breakages when they're due to us updating system.memory.

Changes Made

Add a simple note on our PackageReference to System.Memory, with guidelines.

Testing

Notes

PR is WIP.

benvillalobos avatar Jul 20 '22 21:07 benvillalobos

Note to self: Also add the note to the relevant places here: https://github.com/dotnet/msbuild/pull/7680/files

benvillalobos avatar Jul 20 '22 22:07 benvillalobos

I think we should go forward with this path--maybe with even stronger warnings since it's subtle and painful. @BenVillalobos can you adopt some of the changes and we'll get it merged?

rainersigwald avatar Oct 10 '22 15:10 rainersigwald

@rainersigwald brought in your suggestion but couldn't find where we would file VS breaking changes. Feel free to merge since this is better than what we have today.

benvillalobos avatar Oct 10 '22 16:10 benvillalobos

Added link to internal guidelines, should be good to go

benvillalobos avatar Oct 11 '22 23:10 benvillalobos