[main] Update dependencies from dotnet/roslyn

[dotnet-maestro[bot]]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: 848bf81b-14ec-482f-6736-08da008bd46a
• Build: 20220804.1
• Date Produced: August 4, 2022 9:28:21 AM UTC
• Commit: 83ae84b2a99a0bb1cb83525db21d467b99fd0159
• Branch: refs/heads/release/dev17.4-vs-deps

• Updates:
  • Microsoft.Net.Compilers.Toolset: from 4.3.0-3.22329.30 to 4.4.0-1.22404.1

[Forgind]

Should get a review from someone else before merging, since I made the last change.

[rainersigwald]

Can you explain why you made that change? It looks like the PR was green.

[Forgind]

It wasn't. That check is lying.

[Forgind]

From jaredpar: This is the first time MSBuild has used a compiler that has the new mtehod group to delegate caching feature. That changed the behavior of this line:

SendDataDelegate transportDelegate = PacketProcessor;

Prior to this version this was always a delegate allocation, now though it's a cached delegate conversion. That means the transportDelegate is cached here and likely keeping what you expected to be collected in memory

[rainersigwald]

Great info to put in the commit message . . .

[Forgind]

I'm assuming it will be squashed anyway, so my commit message would disappear. You're right that it'll be good to include in the squash message.

[rainersigwald]

I would not recommend squashing this, since it required an update to our code.

[rokonec]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).