msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Logs warning message when property AllowFailureWithoutError is set to…

Open FrtLoop opened this issue 2 years ago • 2 comments

… True

Fixes #6633

Context

No messages are logged at all if the build fails and AllowFailureWithoutError is set to True.

Changes Made

Moved the logic check for AllowFailureWithoutError to the nested if-else statement so that a warning message is logged if AllowFailureWithoutError is set to True and if AllowFailureWithoutError is set to False then an error is logged instead.

Testing

Added line to relevant Unit Test to check for warning messages in cases where AllowFailureWithoutError is set to True.

Notes

FrtLoop avatar Mar 26 '22 17:03 FrtLoop

CLA assistant check
All CLA requirements met.

dnfadmin avatar Mar 26 '22 17:03 dnfadmin

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: FrtLoop sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

dnfadmin avatar Mar 26 '22 17:03 dnfadmin

Closing this for now. Feel free to reopen it when you're ready.

Forgind avatar Oct 06 '22 21:10 Forgind