Fix importance check for target-skipped messages

Open rainersigwald opened this issue 4 months ago • 4 comments

https://github.com/dotnet/msbuild/pull/12226 introduced a bug: MessageImportance.Low is (numerically) the highest value, so nothing is ever greater than it is. This caused the problems observed in https://github.com/microsoft/testfx/pull/6426 (thanks @Youssef1313 for diagnosing this!).

Reverse the comparison and extract a method to avoid this confusion in the future.

Aug 26 '25 16:08 rainersigwald

Any update here please @rainersigwald ?

Sep 23 '25 14:09 Youssef1313

Ping @rainersigwald

Oct 06 '25 06:10 Youssef1313

Unfortunately it looks like this is not going to be fixed in 10.0.1xx. VS would consider it a regression so we need a deeper solution.

Oct 06 '25 16:10 rainersigwald

@rainersigwald @baronfel any news about this bug?

Nov 27 '25 15:11 Evangelink