Add fast-paths for ToolLocationHelper property functions

[Copilot]

trafficstars

This PR adds fast-path implementations for two commonly used ToolLocationHelper property functions that were identified as performance bottlenecks in template projects:

• GetPlatformSDKLocation(String, String)
• GetPlatformSDKDisplayName(String, String)

Problem

When building template projects in .NET 10.0.100-preview.5, these property functions don't have fast paths and require expensive reflection calls during project evaluation. The tracing output showed:

ReceiverType=Microsoft.Build.Utilities.ToolLocationHelper; ObjectInstanceType=; MethodName=GetPlatformSDKLocation(String, String)
ReceiverType=Microsoft.Build.Utilities.ToolLocationHelper; ObjectInstanceType=; MethodName=GetPlatformSDKDisplayName(String, String)

Solution

Added fast-path implementations in WellKnownFunctions.cs following the established pattern:

1. Added project reference to Microsoft.Build.Utilities.csproj in the Build project to access ToolLocationHelper
2. Implemented fast-paths for both methods with proper argument validation using ParseArgs.TryGetArgs
3. Added test coverage to verify the implementation works correctly

The fast-paths avoid the expensive reflection mechanism and provide direct calls to the underlying methods when the signature matches exactly (two string parameters).

Changes

• src/Build/Microsoft.Build.csproj: Added project reference to Utilities
• src/Build/Evaluation/Expander/WellKnownFunctions.cs: Added fast-path implementations
• src/Build.UnitTests/Evaluation/Expander_Tests.cs: Added test case

Testing

• ✅ Successfully built entire solution
• ✅ Added and verified test case TestToolLocationHelperFastPaths
• ✅ Verified existing ToolLocationHelper tests still pass
• ✅ Confirmed fast-paths execute without errors and return expected results

Fixes #12024.

[!WARNING]

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• dnceng.pkgs.visualstudio.com
  • Triggering command: dotnet build src/Build/Microsoft.Build.csproj --configuration Debug --verbosity minimal (dns block)
  • Triggering command: dotnet test src/Build.UnitTests/Microsoft.Build.Engine.UnitTests.csproj --filter TestToolLocationHelperFastPaths --configuration Debug --verbosity normal (dns block)
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.