msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

[main] Source code updates from dotnet/dotnet

Open dotnet-maestro[bot] opened this issue 6 months ago • 3 comments
trafficstars

[!NOTE] This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

dotnet-maestro[bot] avatar May 21 '25 02:05 dotnet-maestro[bot]

/azp run

AR-May avatar Jun 02 '25 11:06 AR-May

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 02 '25 11:06 azure-pipelines[bot]

this has a couple test failures, can someone please take a look at them?

akoeplinger avatar Jun 13 '25 12:06 akoeplinger

I am on it now

AR-May avatar Jun 17 '25 15:06 AR-May

The packageSourceMapping enabled in NuGet.config at repo level causes the package source configured in nuget.config for the tests is not considered and results in the test failures. It was ever fixed in https://github.com/dotnet/msbuild/pull/11854. But the enabled packageSourceMapping at repo level subsequently broke internal build step that restore internal tools using eng\common\internal\NuGet.config becuase its packages source was not considered, see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11614135&view=logs&j=bb592630-4b9d-53ad-3960-d954a70a95cf&t=cec29cdc-34bb-52dc-f525-f2be67883d7f&l=34. Then the update was reverted by https://github.com/dotnet/msbuild/pull/11859 to unblock internal build.

GangWang01 avatar Jun 19 '25 06:06 GangWang01

The test errors are fixed by the @GangWang01's fix from the previous PR.

The MSBuild CI will indeed still fail if we merge this PR because of the eng\common\internal\NuGet.config. I suggested a fix for arcade that should fix this config for us: https://github.com/dotnet/arcade/pull/15918. Let's wait until it is merged and flow to msbuild before we can merge this PR.

AR-May avatar Jun 19 '25 12:06 AR-May

It should be safe to take after merging https://github.com/dotnet/msbuild/pull/12062

AR-May avatar Jun 24 '25 13:06 AR-May