msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

[Feature Request]: Reduce the wrapping around SDK Resolver messages when only one resolver is actually invoked

Open baronfel opened this issue 1 year ago • 1 comments

Summary

In https://github.com/dotnet/sdk/pull/41268 I was able to use the SDK Resolver features to ensure that only the NuGet SDK resolver was used for a restore. In this case we should be able to remove MSBuild wrapping around the 'error list' and only surface the single Resolver's message.

Background and Motivation

We want to remove visual noise around error experiences and make it easier for users to diagnose the core problems.

Proposed Feature

https://github.com/dotnet/msbuild/blob/003252215533cca375dfc6578d8cb9e029418f37/src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs#L277-L280 should change the way it logs to not log the wrapper if only one resolver was used.

Alternative Designs

No response

baronfel avatar May 30 '24 14:05 baronfel

Makes sense to me. A small change in logging.

AR-May avatar Jun 04 '24 11:06 AR-May

Hey! I noticed this issue is still open and not currently assigned. I’ve made some progress on a potential fix and wanted to check if it’s okay to go ahead and open a PR for it. Let me know if it needs more discussion first.

ana1250 avatar Apr 14 '25 09:04 ana1250

@ana1250 that sounds great! Feel free to go ahead and open that PR.

baronfel avatar Apr 14 '25 12:04 baronfel

Thanks! I have raised a PR.

ana1250 avatar Apr 14 '25 13:04 ana1250