maui icon indicating copy to clipboard operation
maui copied to clipboard

Fix SwitchCell not compliant with best accessibility practices

Open dawidpieper opened this issue 2 years ago • 5 comments

Description of Change

For screenreader users on iOS and Android, SwitchCell is reported as two objects: one being the label, and one the switch itself. It's always the best practice to combine them into one navigation element, being a labeled switch.

Issues Fixed

Fixes #6683

dawidpieper avatar May 06 '22 15:05 dawidpieper

CLA assistant check
All CLA requirements met.

dnfadmin avatar May 06 '22 15:05 dnfadmin

Seems to work, tested on Android 11 and iOS 15.4.1. Ready for review.

dawidpieper avatar May 06 '22 17:05 dawidpieper

Note, PR incorrectly marked as closing # 6648, in fact closing # 6683.

dawidpieper avatar May 06 '22 17:05 dawidpieper

/azp run

rmarinho avatar Jun 30 '22 11:06 rmarinho

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jun 30 '22 11:06 azure-pipelines[bot]

Hi @dawidpieper. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

ghost avatar Jan 27 '23 17:01 ghost

Hi @dawidpieper. It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

ghost avatar Feb 06 '23 18:02 ghost