dotnet
Remove UWP BootstrapHelper
Description
We have this code that was added in https://github.com/xamarin/Xamarin.Forms/pull/11400 for UWP.
https://github.com/dotnet/maui/blob/e37b7bb2445348622e22c516044ac4c537d18f6e/src/Compatibility/Core/src/Windows/BootstrapHelper.cs#L7-L40
Is this still necessary? Can it be removed? It is not trim-compatible since the method being referenced could be trimmed from the app.
cc @StephaneDelcroix @jsuarezruiz
Steps to Reproduce
N/A
Version with bug
Unknown/Other (please specify)
Last version that worked well
Unknown/Other
Affected platforms
Windows
Affected platform versions
all
Did you find any workaround?
No response
Relevant log output
No response
Since Windows is no longer UWP, I am not sure it is relevant anymore. What happens if you delete it? Does Windows still launch?
This is used for XAML Hot Reload for WinUI; it's a part of the injection mode for getting our assemblies added to a users project after it's setup and started.
It's 100% required for that to work right now, so we can't get rid of it. But it should only be in Debug builds, if it's showing up in release builds then it shouldn't be and we should get rid of that from it.
And yeah, the name is misleading. It was used for UWP Xamarin.Forms support, but it's also for WinUI, and we didn't change the names around for interop reasons. Technically, it's the same stack.
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.
This is going to require that we can link windows applications. Right now we can't because WinUI is not marked as trimmable, so the linker fails out the gate.
See also: https://dev.azure.com/microsoft/OS/_workitems/edit/35181693/