maui
maui copied to clipboard
dotnet
[iOS] Fixed OnNavigatedTo not triggered for tabs in More section of TabbedPage
Issue Detail
OnNavigatedTo not called when navigate to the tabs in more tab in iOS.
Root cause
On iOS, when a tab is selected from the "More" section of a TabbedPage, the navigation event OnNavigatedTo is not triggered. This is because the CurrentPage property is not updated when selecting tabs from the "More" section, resulting in missing navigation lifecycle events for those tabs.
Description of change
Updated the CurrentPage using delegate when accessing tabs in More section resolves the issue.
Issues Fixed
Fixes https://github.com/dotnet/maui/issues/16175
Screenshots
| Before Issue Fix | After Issue Fix |
|---|---|
Hey there @@Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
![dotnet-policy-service[bot] avatar](https://avatars.githubusercontent.com/in/285228?v=4 "Published by a pub.dev verified publisher"){kind=small}
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Seems to keep failing: TabbedPageTabEventsTriggeredInMoreSection
The app was expected to be running still, investigate as possible crash TearDown : The app was expected to be running still, investigate as possible crashCould you review it?
@jsuarezruiz I have verified the test TabbedPageTabEventsTriggeredInMoreSection locally, and it passed without any issues. Could you please re-run the CI to confirm the results?
Seems to keep failing: TabbedPageTabEventsTriggeredInMoreSection
The app was expected to be running still, investigate as possible crash TearDown : The app was expected to be running still, investigate as possible crashCould you review it?
@jsuarezruiz I have verified the test
TabbedPageTabEventsTriggeredInMoreSectionlocally, and it passed without any issues. Could you please re-run the CI to confirm the results?
Yes, running it again.