maui
maui copied to clipboard
dotnet
[Android] Prevent Picker from Gaining Focus on Touch
[!NOTE] Are you waiting for the changes in this PR to be merged? It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This PR brings Picker behavior on Android in line with DatePicker and TimePicker, in support of the enhancement described in #8945.
Currently, the Picker's platform control is focusable on touch, and a lot of custom logic has been implemented to make it work with this focus behavior. However, even with that logic, the platform control does not lose focus automatically when the dialog is dismissed — the Focus event fires, but the corresponding Unfocus event does not trigger when the dialog closes. This has led to some weird bugs.
In contrast, both DatePicker and TimePicker are not focusable on touch, so obviously, their Focused and Unfocused events do not fire.
This PR makes Picker behave the same way — by making it non-focusable on Touch, we avoid the current awkward focus lifecycle and ensure consistent behavior across all picker types, paving the way for future improvements with #8945.
CC @PureWeen
Supersedes #25319
Related to #8946 Related to #6252
Issues Fixed
Fixes #19739 Fixes #8546 Fixes #13503 Fixes #24862 Fixes #28121 Fixes #21704 Fixes #15394
Making a note here that we need to validate keyboard interactions and TalkBack to make sure everything works as expected
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
We should make sure to maintain this behavior https://github.com/dotnet/maui/pull/25319#pullrequestreview-2393277222