maui icon indicating copy to clipboard operation
maui copied to clipboard

Fix for [iOS] Use non-overridden traits in AppInfoImplementation.RequestTheme

Open SuthiYuvaraj opened this issue 1 year ago • 2 comments

Root Cause

While updating the requested theme, the default TrailCollection is obtained, which does not return non-overridden traits and does not take the system theme into account.

Description of Change

UIScreen.MainScreen.TraitCollection is obtained , which will return non overridden traits based on the system theme

Issues Fixed

Fixes #23411

Output Video

Before Issue Fix After Issue Fix

SuthiYuvaraj avatar Oct 24 '24 09:10 SuthiYuvaraj

The fix ensures the theme updates correctly on the current page, but the main page still retains the previously requested theme, even when updating the application's current theme.

@filipnavara, do you have any thoughts on this?

karthikraja-arumugam avatar Oct 25 '24 13:10 karthikraja-arumugam

do you have any thoughts on this?

I'll have to check again what is going on in the test app. That sounds like the exact behavior this was trying to fix...

filipnavara avatar Oct 25 '24 13:10 filipnavara

/azp run

jsuarezruiz avatar Oct 28 '24 08:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '24 08:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 30 '24 15:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 30 '24 15:10 azure-pipelines[bot]

/rebase

jsuarezruiz avatar Nov 08 '24 09:11 jsuarezruiz

/azp run

jsuarezruiz avatar Nov 08 '24 09:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 08 '24 09:11 azure-pipelines[bot]

/rebase

sheiksyedm avatar Nov 19 '24 07:11 sheiksyedm

/azp run

jsuarezruiz avatar Nov 20 '24 10:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 20 '24 10:11 azure-pipelines[bot]

/azp run

mattleibow avatar Jan 08 '25 14:01 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 08 '25 14:01 azure-pipelines[bot]

/azp run

PureWeen avatar Jan 14 '25 19:01 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 14 '25 19:01 azure-pipelines[bot]

  • Failing tests are unrelated

PureWeen avatar Jan 15 '25 15:01 PureWeen