maui
maui copied to clipboard
Fix for [iOS] Use non-overridden traits in AppInfoImplementation.RequestTheme
Root Cause
While updating the requested theme, the default TrailCollection is obtained, which does not return non-overridden traits and does not take the system theme into account.
Description of Change
UIScreen.MainScreen.TraitCollection is obtained , which will return non overridden traits based on the system theme
Issues Fixed
Fixes #23411
Output Video
| Before Issue Fix | After Issue Fix |
|---|---|
The fix ensures the theme updates correctly on the current page, but the main page still retains the previously requested theme, even when updating the application's current theme.
@filipnavara, do you have any thoughts on this?
do you have any thoughts on this?
I'll have to check again what is going on in the test app. That sounds like the exact behavior this was trying to fix...
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/rebase
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/rebase
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
- Failing tests are unrelated