maui icon indicating copy to clipboard operation
maui copied to clipboard

TableView title issue fix on iOS and windows platforms.

Open devanathan-vaithiyanathan opened this issue 1 year ago • 5 comments

Root cause

  • On Windows, the TableSelection and TableRoot title properties were converted to lowercase using a converter.
  • On iOS 14.0 and later, the table selection text logic was not implemented.

Description of Change

  • Removed the converter from the TableSelection and TableRoot title properties on Windows.
  • Implemented the table selection logic for iOS 14.0 and later.

Issues Fixed

Fixes #17123

Tested the behaviour in the following platforms

  • [x] Android
  • [x] Windows
  • [x] iOS
  • [x] Mac

Output Screenshot

Before After
Windows
Windows
iOS
iOS

Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

/azp run

jsuarezruiz avatar Oct 22 '24 12:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 12:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 25 '24 10:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 25 '24 10:10 azure-pipelines[bot]

/rebase

Shalini-Ashokan avatar Nov 07 '24 06:11 Shalini-Ashokan

/azp run

jsuarezruiz avatar Nov 07 '24 08:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 07 '24 08:11 azure-pipelines[bot]

LGTM, tested en Android, iOS and Windows and with the changes, the TableView section header behavior is aligned.

jsuarezruiz avatar Nov 07 '24 10:11 jsuarezruiz

/rebase

Shalini-Ashokan avatar Nov 21 '24 13:11 Shalini-Ashokan

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 21 '24 18:11 azure-pipelines[bot]

@PureWeen, I removed the iOS changes, ensured that the PR only includes the WinUI changes.

Shalini-Ashokan avatar Nov 22 '24 06:11 Shalini-Ashokan

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 26 '24 10:11 azure-pipelines[bot]

/azp run

PureWeen avatar Nov 27 '24 04:11 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 27 '24 04:11 azure-pipelines[bot]

  • failing tests are unrelated

PureWeen avatar Dec 04 '24 18:12 PureWeen