maui
maui copied to clipboard
TableView title issue fix on iOS and windows platforms.
Root cause
- On Windows, the TableSelection and TableRoot title properties were converted to lowercase using a converter.
- On iOS 14.0 and later, the table selection text logic was not implemented.
Description of Change
- Removed the converter from the TableSelection and TableRoot title properties on Windows.
- Implemented the table selection logic for iOS 14.0 and later.
Issues Fixed
Fixes #17123
Tested the behaviour in the following platforms
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
Output Screenshot
| Before | After |
|---|---|
| Windows |
Windows |
| iOS |
iOS |
Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/rebase
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
LGTM, tested en Android, iOS and Windows and with the changes, the TableView section header behavior is aligned.
/rebase
Azure Pipelines successfully started running 3 pipeline(s).
@PureWeen, I removed the iOS changes, ensured that the PR only includes the WinUI changes.
Azure Pipelines successfully started running 3 pipeline(s).
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
- failing tests are unrelated