maui
maui copied to clipboard
dotnet
Perf : ButtonContentTypeConverter now using InvariantCulture to parse…
While investigating performance issues in my Android app, I noticed that the ButtonContentTypeConverter was parsing a double without providing a Culture and that is leading to perf issue as described in this blog post.
Description of Change
Update ButtonContentTypeConverter to use CultureInfo.InvariantCulture when performing double.parse(xxx).
Hey there @jonathanantoine! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
![dotnet-policy-service[bot] avatar](https://avatars.githubusercontent.com/in/285228?v=4 "Published by a pub.dev verified publisher"){kind=small}
While investigating performance issues in my Android app, I noticed that the ButtonContentTypeConverter was parsing a double without providing a Culture and that is leading to perf issue as described in this blog post.
Just curious: What impact do you see in your app?
While investigating performance issues in my Android app, I noticed that the ButtonContentTypeConverter was parsing a double without providing a Culture and that is leading to perf issue as described in this blog post.
Just curious: What impact do you see in your app?
A decrease in performance because it's costly to figure out the current culture the first time on Android. It can be 50 to 100ms on some device.