maui icon indicating copy to clipboard operation
maui copied to clipboard

Fixed [Android] Label's HorizontalTextAlignment property is not updated properly at runtime

Open NirmalKumarYuvaraj opened this issue 1 year ago • 7 comments

Root Cause

Android The text alignment property of the Android TextView does not update at runtime, causing the text alignment to remain unchanged.

Description of Change

We can resolve this issue by using gravity along with the text alignment logic.

Validated the behaviour in the following platforms

  • [x] Android
  • [x] Windows
  • [x] iOS
  • [x] Mac

Issues Fixed

Fixes #11655

Output

Android

Before After

NirmalKumarYuvaraj avatar Oct 10 '24 11:10 NirmalKumarYuvaraj

/azp run

jsuarezruiz avatar Oct 17 '24 11:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 17 '24 11:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 22 '24 13:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 13:10 azure-pipelines[bot]

/rebase

jsuarezruiz avatar Oct 23 '24 08:10 jsuarezruiz

/azp run

jsuarezruiz avatar Oct 25 '24 10:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 25 '24 10:10 azure-pipelines[bot]

I am going to trigger the Android UITests again, and test locally to be sure but this ui test image Seems to fail after the changes.

@jsuarezruiz I ran the specified failing test case in Android API 30 on my local machine, and it passed successfully.Please find the screenshot for the same.

image

image

NirmalKumarYuvaraj avatar Oct 30 '24 10:10 NirmalKumarYuvaraj

/azp run

jsuarezruiz avatar Nov 13 '24 12:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 13 '24 12:11 azure-pipelines[bot]

/rebase

NirmalKumarYuvaraj avatar Dec 03 '24 09:12 NirmalKumarYuvaraj

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 13 '24 13:12 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Jan 21 '25 12:01 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 21 '25 12:01 azure-pipelines[bot]

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 23 '25 14:01 azure-pipelines[bot]

/rebase

jsuarezruiz avatar Mar 18 '25 09:03 jsuarezruiz

/azp run

jsuarezruiz avatar Mar 25 '25 07:03 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Mar 25 '25 07:03 azure-pipelines[bot]

/rebase

jsuarezruiz avatar Jun 13 '25 11:06 jsuarezruiz

/rebase

jsuarezruiz avatar Jul 15 '25 12:07 jsuarezruiz

/azp run

jsuarezruiz avatar Jul 15 '25 12:07 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 15 '25 12:07 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Jul 28 '25 11:07 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 28 '25 11:07 azure-pipelines[bot]

/rebase

jsuarezruiz avatar Oct 27 '25 10:10 jsuarezruiz

I no longer can reproduce the bug in maui 10.0.20. closing this PR

StephaneDelcroix avatar Dec 03 '25 10:12 StephaneDelcroix