maui [Android] ToolbarItem Icon Color

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/24676

Before	After

Oct 05 '24 13:10 kubaflo

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Oct 05 '24 13:10 dotnet-policy-service[bot]

/rebase

Oct 23 '24 09:10 jsuarezruiz

/azp run

Oct 23 '24 09:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Oct 23 '24 09:10 azure-pipelines[bot]

/rebase

Oct 29 '24 15:10 jsuarezruiz

/rebase

Nov 12 '24 14:11 jsuarezruiz

/azp run

Nov 12 '24 14:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Nov 12 '24 14:11 azure-pipelines[bot]

/azp run

Nov 13 '24 11:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Nov 13 '24 11:11 azure-pipelines[bot]

/azp run

Nov 18 '24 11:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Nov 18 '24 11:11 azure-pipelines[bot]

Sorry, the build is failing:

D:\a\_work\1\s\src\Compatibility\Core\src\Android\AppCompat\NavigationPageRenderer.cs(915,112): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net9.0-android35.0]
    9443 Warning(s)
    1 Error(s)

Let me know if need help with something.

Yes, can you help me with this one? I don't know how to run the Compatibility project so that I know where the errors are.

Nov 20 '24 10:11 kubaflo

Sorry, the build is failing:
D:\a\_work\1\s\src\Compatibility\Core\src\Android\AppCompat\NavigationPageRenderer.cs(915,112): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\_work\1\s\src\Compatibility\Core\src\Compatibility.csproj::TargetFramework=net9.0-android35.0]
    9443 Warning(s)
    1 Error(s)
Let me know if need help with something.
Yes, can you help me with this one? I don't know how to run the Compatibility project so that I know where the errors are.

Sure, fixed.

Nov 20 '24 11:11 jsuarezruiz

/azp run

Nov 21 '24 09:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Nov 21 '24 09:11 azure-pipelines[bot]

@kubaflo this seems to end up using the same color as the 'title' on android.

In the linked issue they are trying to get the color to be the Shell.ForegroundColor... I'm not sure if this is exactly correct, but it seems like there's no way otherwise to specify the icon color to differ from the title / text color...

Thoughts? /cc @PureWeen

Feb 24 '25 15:02 Redth

@Redth thanks for noticing! You're right! It should color the icon based on the ForegroundColor as opposed to TitleColor Fixed :)

Feb 25 '25 00:02 kubaflo

/azp run

Feb 25 '25 19:02 Redth

/azp run

Feb 26 '25 21:02 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

Feb 26 '25 21:02 azure-pipelines[bot]

Does the WinUI screenshot on this PR indicate an additional bug? Since the icon isn't showing up?

It looks like, but I can't fix it

Feb 27 '25 00:02 kubaflo

/rebase

Feb 27 '25 15:02 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

Feb 28 '25 15:02 azure-pipelines[bot]

/rebase

Mar 02 '25 22:03 PureWeen

Does the WinUI screenshot on this PR indicate an additional bug? Since the icon isn't showing up?

It looks like, but I can't fix it

Can you log a bug?

Mar 02 '25 22:03 PureWeen

I am not one for asking people to make PRs bigger, but this is so much overlap with #24985 that I wonder if it is best. We are touching the same test app, tests and images. The actual fix is small enough that it might be worth merging the two.

Mar 12 '25 13:03 mattleibow

/azp run

Mar 17 '25 12:03 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

Mar 17 '25 12:03 azure-pipelines[bot]

Hello guys, thanks for looking into this. :) We also have the same issue, any idea on when we can expect this to be released?

Jul 03 '25 10:07 shnaz