maui icon indicating copy to clipboard operation
maui copied to clipboard

Support for Setting Switch Off State Color

Open devanathan-vaithiyanathan opened this issue 1 year ago • 11 comments

Description of Change

Currently, we can only change the track color for the switch in the "on" state. Support for changing the track color in the "off" state has now been added. A new API called OffColor has been implemented for the switch, allowing us to change the track color when the switch is off as well.

Issues Fixed

Fixes #15695

Tested the behaviour in the following platforms

  • [x] Android
  • [x] Windows
  • [x] iOS
  • [x] Mac
  • [ ] Tizen

/azp run

jsuarezruiz avatar Oct 04 '24 07:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 04 '24 07:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 11 '24 11:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 11 '24 11:10 azure-pipelines[bot]

/rebase

rmarinho avatar Oct 19 '24 23:10 rmarinho

/azp run

rmarinho avatar Oct 21 '24 18:10 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 21 '24 18:10 azure-pipelines[bot]

/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(33,43): error RS0016: Symbol 'OffColorProperty' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0] /Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(55,4): error RS0016: Symbol 'OffColor.get' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0] /Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(56,4): error RS0016: Symbol 'OffColor.set' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0] 0 Warning(s) 3 Error(s)

The public API for the Tizen platform has been added.

/azp run

jsuarezruiz avatar Oct 25 '24 10:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 25 '24 10:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 28 '24 11:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '24 11:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 30 '24 08:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 30 '24 08:10 azure-pipelines[bot]

@PureWeen This should retarget to net9.0, right?

jsuarezruiz avatar Nov 06 '24 14:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 06 '24 15:12 azure-pipelines[bot]

/azp run

rmarinho avatar Dec 18 '24 15:12 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 18 '24 15:12 azure-pipelines[bot]

/azp run

PureWeen avatar Jan 16 '25 19:01 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 16 '25 19:01 azure-pipelines[bot]

@devanathan-vaithiyanathan Could you rebase to fix the conflicts?

jsuarezruiz avatar Jan 29 '25 12:01 jsuarezruiz

@devanathan-vaithiyanathan Could you rebase to fix the conflicts?

Conflicts have been resolved

This one will need to wait for .NET10

Can you rebase this for our net10 branch?

I have rebased it onto the net10 branch. Could you please check and let me know if you have any concerns?

/azp run

jfversluis avatar Feb 13 '25 09:02 jfversluis

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

azure-pipelines[bot] avatar Feb 13 '25 09:02 azure-pipelines[bot]

Successful build here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11007466&view=results

jfversluis avatar Feb 13 '25 12:02 jfversluis