maui
maui copied to clipboard

Published 20 hours ago •

Reame
Issues

Fix TabBar visibility when navigating back from a non-tabbed page to a tabbed page

Open SuthiYuvaraj opened this issue 1 year ago • 17 comments

trafficstars

Root Cause:

The issue occurred because the code checked the parent ShellItem for tab visibility, even when Shell.GetTabBarIsVisible(Page) returned true, leading to incorrect tab visibility behavior.

Description of Change:

The fix ensures that if Shell.GetTabBarIsVisible(Page) returns true, the tab bar is shown. If it returns false, only then is the parent ShellItem checked, ensuring the correct visibility behavior.

Issue Fixed:

Fixes #17390

Tested the behaviour in the following platforms

[x] Android
[x] Windows
[x] iOS
[x] Mac

###Output Video

Before Issue Fix	After Issue Fix

Sep 30 '24 11:09 SuthiYuvaraj

/azp run

Oct 03 '24 11:10 jfversluis

Azure Pipelines successfully started running 3 pipeline(s).

Oct 03 '24 11:10 azure-pipelines[bot]

/azp run

Oct 04 '24 07:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Oct 04 '24 07:10 azure-pipelines[bot]

/azp run

Oct 08 '24 13:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Oct 08 '24 13:10 azure-pipelines[bot]

/rebase

Oct 09 '24 13:10 jsuarezruiz

/azp run

Oct 10 '24 13:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Oct 10 '24 13:10 azure-pipelines[bot]

/azp run

Oct 11 '24 11:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Oct 11 '24 11:10 azure-pipelines[bot]

/azp run

Oct 14 '24 10:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Oct 14 '24 10:10 azure-pipelines[bot]

/azp run

Oct 15 '24 16:10 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

Oct 15 '24 16:10 azure-pipelines[bot]

/azp run

Oct 25 '24 10:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Oct 25 '24 10:10 azure-pipelines[bot]

/azp run

Nov 04 '24 15:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Nov 04 '24 15:11 azure-pipelines[bot]

/rebase

Nov 18 '24 12:11 jsuarezruiz

/azp run

Nov 20 '24 10:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

Nov 20 '24 10:11 azure-pipelines[bot]

Azure Pipelines successfully started running 3 pipeline(s).

Dec 13 '24 10:12 azure-pipelines[bot]

/rebase

Dec 16 '24 12:12 jfversluis

Azure Pipelines successfully started running 3 pipeline(s).

Dec 16 '24 13:12 azure-pipelines[bot]

/rebase

Dec 18 '24 10:12 jfversluis

Azure Pipelines successfully started running 3 pipeline(s).

Dec 18 '24 14:12 azure-pipelines[bot]

I removed the change inside ShellPageRendererTracker and the test still passes.

Maybe this is already fixed? or the does the text need to be adjusted?

Yes @PureWeen , The issue is no longer reproduced in the recent source, as it has been resolved in #25700 PR , Hence closing the PR.

Dec 20 '24 10:12 SuthiYuvaraj