maui icon indicating copy to clipboard operation
maui copied to clipboard

Improve TextToSpeech function by adding a speech rate parameter

Open Zerod159 opened this issue 1 year ago • 8 comments

Description of Change

Added a speech rate parameter to SpeechOptions and implemented the rate on all platforms.

Issues Fixed

Fixed in bug in the Tizen implementation. tts.AddText last Parameter is speed and not pitch. This needs to be options.rate.

Zerod159 avatar Sep 17 '24 07:09 Zerod159

@dotnet-policy-service agree

Zerod159 avatar Sep 17 '24 07:09 Zerod159

Could you retarget to the net9.0 branch?

I have :)

Zerod159 avatar Oct 07 '24 16:10 Zerod159

Can anybody shed some light regarding progress on this feature? I would love to have that too...

whann0205 avatar Oct 14 '24 07:10 whann0205

I don't know if I should or can do anything to speed up the process.

Zerod159 avatar Oct 18 '24 14:10 Zerod159

Well as i can see they want to target that change to .net9. Since i need to release a stable app at end of the year, i cannot see that i am going to migrate to .net9 in order to have that feature. Is it not possible to change it in .net8?

whann0205 avatar Oct 18 '24 15:10 whann0205

/azp run

jsuarezruiz avatar Oct 23 '24 09:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 23 '24 09:10 azure-pipelines[bot]

Unfortunately, I don't know much about the build tasks. Can someone explain to me what the problem is with: Unable to determine the domain name?

Zerod159 avatar Oct 27 '24 09:10 Zerod159

Please rebase this on main

rmarinho avatar Nov 18 '24 10:11 rmarinho

Sorry this took a while, if you're still interested in getting this merged, please feel free to tag me and see if we can make it happen. Thanks!

jfversluis avatar Dec 10 '24 10:12 jfversluis

Hello @jfversluis , I am still interested in the code being merged. But I still don't know what the problem is. If there is anything I can do, I am happy to do it.

Zerod159 avatar Dec 20 '24 12:12 Zerod159

Unfortunately, I don't know much about the build tasks. Can someone explain to me what the problem is with: Unable to determine the domain name?

@Zerod159 I'm not sure what you mean. To move this forward, I believe you need to merge main branch (or rebase on top of main which is preferable).

edit: If there is a problem with build or something, feel free to ask.

MartyIX avatar Dec 20 '24 12:12 MartyIX

Indeed can you please rebase on main?

jfversluis avatar Dec 20 '24 14:12 jfversluis

I merged my changes to main. what am i doing wrong?

Zerod159 avatar Jan 03 '25 15:01 Zerod159

/azp run

PureWeen avatar Jan 07 '25 18:01 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 07 '25 18:01 azure-pipelines[bot]

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 18 '25 14:01 azure-pipelines[bot]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

azure-pipelines[bot] avatar Feb 10 '25 08:02 azure-pipelines[bot]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

azure-pipelines[bot] avatar Feb 10 '25 13:02 azure-pipelines[bot]

Build succeeded here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10985162&view=results

jfversluis avatar Feb 11 '25 08:02 jfversluis

🚨 API change(s) detected @davidbritch FYI