IndicatorView with DataTemplate - improvements

[kubaflo]

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/21980 Fixes https://github.com/dotnet/maui/issues/24739 Closes https://github.com/dotnet/maui/pull/24717

Before	After

[PureWeen]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[rmarinho]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

@kubaflo Could you rebase to fix the conflicts? Thanks in advance.

[kubaflo]

@jsuarezruiz rebased and fixed conflicts

[jsuarezruiz]

/rebase

[PureWeen]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[kubaflo]

@rmarinho I see, this is a screenshot from 2 months ago, I just reuploaded a new one :)

Unfortunately,, I cannot fix this problem: https://github.com/dotnet/maui/pull/24776#discussion_r1817845429, because I don't have Windows

[rmarinho]

/rebase

[rmarinho]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[kubaflo]

I double check and the test is crashing on Windows IndicatorViewShouldRenderCorrectly.

https://dev.azure.com/xamarin/public/_build/results?buildId=130815&view=ms.vss-test-web.build-test-results-tab&runId=3514041&resultId=100085&paneView=debug

I cannot fix it on Windows :/ https://github.com/dotnet/maui/pull/24776#issuecomment-2506036415

[rmarinho]

I double check and the test is crashing on Windows IndicatorViewShouldRenderCorrectly. https://dev.azure.com/xamarin/public/_build/results?buildId=130815&view=ms.vss-test-web.build-test-results-tab&runId=3514041&resultId=100085&paneView=debug

I cannot fix it on Windows :/ #24776 (comment)

oh sorry so many comments, let me give it a look .

[PureWeen]

/rebase

[PureWeen]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[rmarinho]

/rebase

[rmarinho]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/rebase

[jsuarezruiz]

/azp run

[kubaflo]

I wonder if instead of setting the WidthRequest and HeightRequest for this one we can override MeasureOverride and provide the proper measure values from that?

For example, as a quick test I did this

#pragma warning disable RS0016 // Add public types and members to the declared API
		protected override Size MeasureOverride(double widthConstraint, double heightConstraint)
#pragma warning restore RS0016 // Add public types and members to the declared API
		{
			var size = base.MeasureOverride(widthConstraint, heightConstraint);

			var width = templatedItemWidth.Value * Count + DefaultPadding * (Count - 1);
			var height = templatedItemHeight.Value;

			return new Size(width, height);

		}

And that worked without having to set the Width/HeightReuqest

Or alternatively

Why don't we override SizeThatFits on MauiPageControl ?

Thanks!

[kubaflo]

I tried on android, but when I change the item, it doesn t change the selected item of the carouselview, also if I click one on the indicator, sometimes it goes to the next item, other it doesn't.

Works fine on iOS

I've checked, and the issue happens when we have the same images in carousel view. It appears to be already existing bug. I've updated the sample in the UI test. Can you have a look if it works for you?

[kubaflo]

@rmarinho This is what happens on main, but I'd rather fix it in a separate PR

Same images	Different images

[kubaflo]

@rmarinho it happens because all of the items have a bindingContext="dotnet_bot.png", so

int GetIndexFromTemplatedCell(global::Android.Views.View view)
{
	int itemIndex = -1;

	if (view is ItemContentView templatedCell && ItemsViewAdapter != null)
	{
		var bContext = (templatedCell?.View as VisualElement)?.BindingContext;
		itemIndex = ItemsViewAdapter.GetPositionForItem(bContext);
	}

	return itemIndex;
}

in CarouselViewOnScrollListener.cs returns the same index for all the elements