maui icon indicating copy to clipboard operation
maui copied to clipboard

Stepper doesn't change increment value when being bound to a double in MVVM context (Windows)

Open devanathan-vaithiyanathan opened this issue 1 year ago • 16 comments

Root cause

When the Stepper value is updated dynamically, the current increment value is not correctly passed to the PlatformView. This issue occurs because the Interval property, which controls the stepper's increment, is not mapped properly to the PlatformView. As a result, the expected behavior of incrementing the stepper value is not consistent.

Description of Change

The interface Interval has been renamed to Increment and is now mapped to the mapIncrement method. All references to Interval have also been renamed to Increment.

API changes

Renamed IStepper.Interval to IStepper.Increment

Issues Fixed

Fixes #20706

Validated the behaviour in the following platforms

  • [x] Android
  • [x] Windows
  • [x] iOS
  • [x] Mac

Output Screenshot

Before Changes

https://github.com/user-attachments/assets/17b99b70-6803-42d3-943e-bcd781329377

After Changes

https://github.com/user-attachments/assets/b053f0a5-e459-4a8e-835f-743a1a8cf7d0

/azp run

PureWeen avatar Aug 26 '24 21:08 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 26 '24 21:08 azure-pipelines[bot]

/azp run

rmarinho avatar Aug 30 '24 16:08 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 30 '24 16:08 azure-pipelines[bot]

Hi @PureWeen , I have reviewed the issue and am currently working on a fix for the ChangeIncrementValue functionality.

Needs rebase

rmarinho avatar Sep 27 '24 13:09 rmarinho

/azp run

jsuarezruiz avatar Oct 09 '24 08:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 09 '24 08:10 azure-pipelines[bot]

Could include an UITest after merge https://github.com/dotnet/maui/pull/25130

jsuarezruiz avatar Oct 09 '24 11:10 jsuarezruiz

/rebase

jsuarezruiz avatar Oct 09 '24 11:10 jsuarezruiz

#25130 has been merged

Can you try it out and add some tests?

Currently working on adding the requested test cases

/rebase

/azp run

jsuarezruiz avatar Oct 22 '24 13:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 13:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 24 '24 13:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 24 '24 13:10 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Oct 28 '24 11:10 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '24 11:10 azure-pipelines[bot]

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 29 '24 11:10 azure-pipelines[bot]

/azp run

rmarinho avatar Nov 16 '24 01:11 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 16 '24 01:11 azure-pipelines[bot]

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 19 '24 13:11 azure-pipelines[bot]

/azp run

jsuarezruiz avatar Nov 21 '24 14:11 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 21 '24 14:11 azure-pipelines[bot]

/rebase

jsuarezruiz avatar Jan 10 '25 11:01 jsuarezruiz

/azp run

PureWeen avatar Jan 16 '25 19:01 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 16 '25 19:01 azure-pipelines[bot]

/azp run

mattleibow avatar Jan 23 '25 13:01 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 23 '25 13:01 azure-pipelines[bot]