maui icon indicating copy to clipboard operation
maui copied to clipboard

`LayoutHandler.Windows`: Store children to a local variable

Open MartyIX opened this issue 2 years ago • 5 comments

Description of Change

The PR trivially attempts to decrease the number of interops.

Issues Fixed

Contributes to #21787

MartyIX avatar Apr 12 '24 09:04 MartyIX

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Maybe we could write an analyzer to detect usages of iterating on members or properties that call platform-specific code.

symbiogenesis avatar Apr 12 '24 19:04 symbiogenesis

It might generate a lot of false positives but it would be a nice tool to run it once in a while IMO.

MartyIX avatar Apr 12 '24 20:04 MartyIX

@rmarinho Could you take a look please?

MartyIX avatar Apr 16 '24 11:04 MartyIX

/azp run

jonathanpeppers avatar Apr 18 '24 13:04 jonathanpeppers

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Apr 18 '24 13:04 azure-pipelines[bot]

Hm, it did not get merged automatically, or I don't understand how the feature work.

MartyIX avatar Apr 19 '24 09:04 MartyIX