maui icon indicating copy to clipboard operation
maui copied to clipboard

added Command and CommandParameter on CheckBox

Open pictos opened this issue 6 months ago • 1 comments

Description of Change

Issues Fixed

Fixes #7394

pictos avatar Feb 20 '24 05:02 pictos

Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Feb 20 '24 05:02 ghost

@rmarinho does maui use inline docs normally or there's some xml file that I should add?

pictos avatar Feb 23 '24 01:02 pictos

Could we also add a simple UITest to show how it renderers check and uncheck and a Visual test.

@rmarinho can you point me to a UITest that I can use as sample... I tried to look into the existing one on Appium project, but couldn't figure out how to create the UI to test

pictos avatar Feb 26 '24 23:02 pictos

@rmarinho does maui use inline docs normally or there's some xml file that I should add?

We use inline docs now. @jfversluis can help you with that if you need.

Could we also add a simple UITest to show how it renderers check and uncheck and a Visual test.

@rmarinho can you point me to a UITest that I can use as sample... I tried to look into the existing one on Appium project, but couldn't figure out how to create the UI to test

Add your UI here : https://github.com/dotnet/maui/blob/main/src/Controls/samples/Controls.Sample.UITests/Issues/Issue19379.xaml#L2

Add your test here: https://github.com/dotnet/maui/blob/main/src/Controls/tests/UITests/Tests/Issues/Issue19379.cs#L27

Run it one time on CI to generate the screenshots and add them here: https://github.com/dotnet/maui/tree/main/src/Controls/tests/UITests/snapshots

rmarinho avatar Feb 29 '24 17:02 rmarinho

does maui use inline docs normally or there's some xml file that I should add?

Yes please add the documentation inline and NOT the external XML files :)

jfversluis avatar Mar 01 '24 18:03 jfversluis

/azp run

mattleibow avatar Jun 06 '24 16:06 mattleibow

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 06 '24 16:06 azure-pipelines[bot]

/rebase

rmarinho avatar Jul 24 '24 13:07 rmarinho