maui icon indicating copy to clipboard operation
maui copied to clipboard

Add new Keyboards for Prompt

Open pictos opened this issue 6 months ago • 1 comments

Description of Change

This PR adds new Keyboard types:

  • Password
  • Date
  • Time

Issues Fixed

Fixes #9913

pictos avatar Jan 27 '24 05:01 pictos

Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 27 '24 05:01 ghost

@pictos I have made a PR on your fork as I was unable to push here. I attempted to add the new keyboards for Tizen

licon4812 avatar Jan 29 '24 22:01 licon4812

@licon4812 thanks for the implementation. Is already merged <3

pictos avatar Jan 29 '24 22:01 pictos

@pictos you're too quick 🤣

licon4812 avatar Jan 29 '24 22:01 licon4812

Oh wow. Looks like Tizen implementation is done thanks to @licon4812.

JoonghyunCho avatar Jan 31 '24 11:01 JoonghyunCho

@rmarinho Should this target the net9.0 branch?

jsuarezruiz avatar Feb 02 '24 13:02 jsuarezruiz

Yeah since this adds API I think we need to only add it on net9.0 @pictos sorry needs rebase :/

rmarinho avatar Feb 07 '24 17:02 rmarinho

@rmarinho what should I do then? From the contribution guide I should always target main, is that obsolete?

pictos avatar Feb 07 '24 21:02 pictos

@pictos I think we need to retarget this to net9.0 and @PureWeen should we update the contrib guide ?

rmarinho avatar Feb 12 '24 01:02 rmarinho

@rmarinho which net9?

pictos avatar Feb 12 '24 02:02 pictos

@pictos https://github.com/dotnet/maui/tree/net9.0

@jsuarezruiz and @PureWeen are going to update the guide thanks for your feedback.

rmarinho avatar Feb 12 '24 15:02 rmarinho

@rmarinho , done

pictos avatar Feb 13 '24 02:02 pictos