maui
maui copied to clipboard
Fixed android toolbar icon change (#19673)
Description of Change
Fixed android toolbar icon change on shell pages
Issues Fixed
Fixes https://github.com/dotnet/maui/issues/19673 Fixes https://github.com/dotnet/maui/issues/19950
https://github.com/dotnet/maui/assets/42434498/14f8d829-5e69-4183-87ad-c7469314db42
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
Added UI Test.
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
Similar PR here https://github.com/dotnet/maui/pull/16796
It would be fantastic if we also had a UI Test that matched the example provided in the description, it could even be a second one that covers #19950, that is, different icons and text being displayed. As seen below, it looks like the test is checking if one icon set on one page is persisting across the others.
@dustin-wojciechowski I've added a Ui Test that covers the #19950 bug like you asked for :)
/rebase
Azure Pipelines successfully started running 3 pipeline(s).
Azure Pipelines successfully started running 3 pipeline(s).
/rebase
@kubaflo @PureWeen do we still need this now we merged #16796?
@jfversluis yes, I don't think we need it anymore. Therefore, I'm closing this pr :)