maui icon indicating copy to clipboard operation
maui copied to clipboard

Fixed android toolbar icon change (#19673)

Open kubaflo opened this issue 1 year ago • 1 comments

Description of Change

Fixed android toolbar icon change on shell pages

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/19673 Fixes https://github.com/dotnet/maui/issues/19950

https://github.com/dotnet/maui/assets/42434498/14f8d829-5e69-4183-87ad-c7469314db42

kubaflo avatar Jan 26 '24 00:01 kubaflo

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 26 '24 00:01 ghost

Added UI Test.

jsuarezruiz avatar Jan 26 '24 11:01 jsuarezruiz

/azp run

rmarinho avatar Feb 01 '24 15:02 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Feb 01 '24 15:02 azure-pipelines[bot]

Similar PR here https://github.com/dotnet/maui/pull/16796

PureWeen avatar Feb 05 '24 16:02 PureWeen

It would be fantastic if we also had a UI Test that matched the example provided in the description, it could even be a second one that covers #19950, that is, different icons and text being displayed. As seen below, it looks like the test is checking if one icon set on one page is persisting across the others.

19673.webm

dustin-wojciechowski avatar Apr 26 '24 18:04 dustin-wojciechowski

@dustin-wojciechowski I've added a Ui Test that covers the #19950 bug like you asked for :)

kubaflo avatar Apr 27 '24 23:04 kubaflo

/rebase

PureWeen avatar May 02 '24 18:05 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 02 '24 18:05 azure-pipelines[bot]

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar May 02 '24 19:05 azure-pipelines[bot]

/rebase

jfversluis avatar May 29 '24 11:05 jfversluis

@kubaflo @PureWeen do we still need this now we merged #16796?

jfversluis avatar May 29 '24 11:05 jfversluis

@jfversluis yes, I don't think we need it anymore. Therefore, I'm closing this pr :)

kubaflo avatar May 29 '24 12:05 kubaflo