maui icon indicating copy to clipboard operation
maui copied to clipboard

Throw error when pushing without wrapping into navigation page

Open kubaflo opened this issue 1 year ago • 3 comments

Description of Change

Throw error when pushing without wrapping into navigation page

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/2013

kubaflo avatar Jan 25 '24 13:01 kubaflo

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 25 '24 13:01 ghost

/azp run

PureWeen avatar Jan 25 '24 16:01 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 25 '24 16:01 azure-pipelines[bot]

As discussed on this live stream this seems not the right place to do things, please let us know if anything is not clear on how to proceed to discuss further. Thank you!

jfversluis avatar Mar 07 '24 19:03 jfversluis

@jfversluis @PureWeen I've added a commit that moves this exception to the Window class and it seems to be working fine :)

kubaflo avatar Mar 08 '24 01:03 kubaflo

/azp run MAUI-UITests-public

jfversluis avatar Mar 19 '24 08:03 jfversluis

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 19 '24 08:03 azure-pipelines[bot]

Thanks for another great contribution @kubaflo !

jfversluis avatar Mar 19 '24 10:03 jfversluis

🚨 API change(s) detected @davidbritch FYI