maui
maui copied to clipboard
Applying visibility change to child controls
Description of Change
Applying visibility change to child controls
Issues Fixed
Fixes https://github.com/dotnet/maui/issues/19139
https://github.com/dotnet/maui/assets/42434498/5d8254f2-6fd5-4798-a909-e131efbd3c65
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
@rmarinho there was a short discussion in this issue https://github.com/dotnet/maui/issues/19139
Hmmm if the changes of IsEnabled
or Input transparent
propagate to child controls then that should be the case with isVisible
Of course it is my opinion and I'm happy to find out why it might not be a good idea.
I will write tests once there is a decision on whether this change makes sense or not.
I added this PR here to address specifically with the next entry capability. I don't think we will need this PR (in regards to the next entry issue), but it could possibly be helpful for a different scenario!
This PR seems sensible, but both WPF and UWP chose not to propagate this value. So I am asking some teams why they decided this: https://github.com/dotnet/wpf/discussions/8774
Can you rebase?
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
Now the question is... Is this a breaking change for a SR that means it should wait for net9.0? Or is it OK and people need to be aware of the change?
@kubaflo Could you rebase and fix the conflicts?. Thanks. Let me know if can help with something.
@jsuarezruiz done :)