maui icon indicating copy to clipboard operation
maui copied to clipboard

Update MSBuild.StructuredLogger

Open JanKrivanek opened this issue 2 years ago • 3 comments

FYI @KirillOsenkov

Context

This is update to the latest version of MSBuild.StructuredLogger, that contains the forward compatibility reading support. The initial MSBuild change to forward compatible logs reading is breaking (log data format needs to be adjusted in order to allow forward compatibile reading for the future) - hence updating the reading code ahead of MSBuild pushing the updated version of binlog writing (https://github.com/dotnet/msbuild/pull/9307) is advisable.

JanKrivanek avatar Jan 11 '24 11:01 JanKrivanek

Hey there @JanKrivanek! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 11 '24 11:01 ghost

/azp run

Redth avatar Jan 12 '24 17:01 Redth

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 12 '24 17:01 azure-pipelines[bot]

@Redth - thank you for running the pipeline. The failing tests doesn't seem to be very stable though:

image image

Can you please rerun or skip?

The Structured Logger seems to be just referenced, but not even called in the codebase:

https://github.com/dotnet/maui/blob/fceed1991abcfb8b4ec1a4f724add04d0849e080/src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/BuildWarningsUtilities.cs#L33 -> https://github.com/dotnet/maui/blob/fceed1991abcfb8b4ec1a4f724add04d0849e080/src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/BuildWarningsUtilities.cs#L575 -> no caller

though in case there is any actuall usage - we'd want you to be on a latest version before we merge the MSBuild update to binlog format (to prevent breaking your build down the road)

JanKrivanek avatar Jan 15 '24 09:01 JanKrivanek

/rebase

Redth avatar Jan 18 '24 15:01 Redth

/azp run

Redth avatar Jan 18 '24 15:01 Redth

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 18 '24 15:01 azure-pipelines[bot]